Skip to content

Skip tests by default in internal rolling builds #7151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephentoub merged 4 commits into from
Dec 15, 2025
Merged

Skip tests by default in internal rolling builds #7151

stephentoub merged 4 commits into from
Dec 15, 2025

Conversation

Copy link
Contributor

Copilot AI commented Dec 12, 2025 •
edited
Loading

Plan to skip tests in internal rolling builds

  • Explore repository structure and understand current pipeline configuration
  • Add a runTests parameter to azure-pipelines.yml (defaults to false)
  • Update Windows job in azure-pipelines.yml to pass skipTests parameter based on runTests
  • Update Ubuntu job in azure-pipelines.yml to pass skipTests parameter based on runTests
  • Update correctness stage job (already has skipTests: true, verified it's correct)
  • Validate the changes by reviewing the YAML syntax
  • Run code review (passed with no issues)
  • Run security checks (no security issues found)
  • Address PR feedback: Add condition to codecoverage stage to only run when tests are executed
  • Make codecoverage stage dependency conditional in post-build validation to prevent issues when stage is skipped
Original prompt

This section details on the original issue you should resolve

<issue_title>Don't run tests for internal rolling builds</issue_title>
<issue_description>We still are running tests in the azdo internal rolling builds.

This can create fragility in the official build and it also opens us up to a greater surface area in our production pipelines.</issue_description>

<agent_instructions>Please update azure-pipelines.yml so that it doesn't run tests. I think this should be specifying skipTests to the BuildAndTest.yml template. Adding a build parameter that would enable tests, but make it off by default.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Microsoft Reviewers: Open in CodeFlow

Copilot AI changed the title [WIP] Update azure-pipelines to skip tests in internal builds Skip tests by default in internal rolling builds Dec 12, 2025
Copilot AI requested a review from ericstj December 12, 2025 22:06
@ericstj ericstj marked this pull request as ready for review December 12, 2025 22:09
@ericstj ericstj requested a review from a team as a code owner December 12, 2025 22:09
@ericstj ericstj requested review from Copilot and joperezr December 12, 2025 22:09
stephentoub
stephentoub approved these changes Dec 12, 2025
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but I defer to @joperezr on whether this will have any unintended negative effects

Copilot AI reviewed Dec 12, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a runTests parameter to Azure Pipelines that allows tests to be skipped by default in internal rolling builds, addressing fragility concerns and reducing production pipeline surface area. By defaulting runTests to false, tests are skipped in automatic CI builds while remaining available for manual execution when needed.

Key changes:

  • Added runTests boolean parameter (default: false) for controlling test execution
  • Updated Windows and Ubuntu build jobs to conditionally skip tests based on the parameter

@ericstj
Copy link
Member

ericstj commented Dec 12, 2025

@copilot address feedback

Copilot AI requested a review from ericstj December 12, 2025 22:58
@stephentoub stephentoub merged commit 2871008 into main Dec 15, 2025
6 checks passed
@stephentoub stephentoub deleted the copilot/update-azure-pipelines-skip-tests branch December 15, 2025 04:34
This was referenced Jan 13, 2026
Merged
Merged
Closed
Closed
Open
This was referenced Jan 14, 2026
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Open
Closed
Open
Merged
Open
Open
Open
Open
Merged
Merged
Open
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@stephentoub stephentoub stephentoub approved these changes

@joperezr joperezr Awaiting requested review from joperezr

+1 more reviewer

@ericstj ericstj ericstj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ericstj ericstj

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't run tests for internal rolling builds

3 participants

@ericstj @stephentoub